Skip to content

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Aug 16, 2019

When d7a90c0 was added,
it potentially reduced the sleep timeout to zero
if we took a snapshot right away, unintentionally
ensuring we did not have any samples inside Julia!

fix #29880 and add a test for the empty printing case

When d7a90c0 was added,
it potentially reduced the sleep timeout to zero
if we took a snapshot right away, unintentionally
ensuring we did not have any samples inside Julia!

fix #29880 and add a test for the empty printing case
@vtjnash vtjnash added test This change adds or pertains to unit tests stdlib Julia's standard library labels Aug 16, 2019
@JeffBezanson
Copy link
Member

Nice, these failures are really common.

@vtjnash vtjnash merged commit b0ff444 into master Aug 17, 2019
@vtjnash vtjnash deleted the jn/8628 branch August 17, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stdlib Julia's standard library test This change adds or pertains to unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stdlib/Profile test failure (no samples collected)

2 participants