Skip to content

use precompile generation for Distributed instead of hardcoded list #33077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

use precompile generation for Distributed instead of hardcoded list #33077

merged 1 commit into from
Oct 16, 2019

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented Aug 26, 2019 •
edited
Loading

Optionally, we just delete the precompile file in Distributed and do no precompilation for it.

Fixes #31938

@KristofferC KristofferC added parallelism Parallel or distributed computation compiler:precompilation Precompilation of modules latency Latency labels Aug 26, 2019
@KristofferC KristofferC reopened this Aug 26, 2019
@JeffBezanson
Copy link
Member

JeffBezanson commented Aug 27, 2019

With this we could probably delete the precompile.jl file for Serialization as well.

@KristofferC
Copy link
Member Author

KristofferC commented Oct 2, 2019

Removed the Sockets precompile file as well. I looked at the generated precompile statements and there was a bunch of Socket stuff in there.

@KristofferC
Copy link
Member Author

KristofferC commented Oct 16, 2019

Good to go?

@JeffBezanson JeffBezanson merged commit 220681f into master Oct 16, 2019
@JeffBezanson JeffBezanson deleted the kc/distributed branch October 16, 2019 17:34
@JeffBezanson
Copy link
Member

JeffBezanson commented Oct 29, 2019

It's surprising how much time this adds to the build.
Before:

Generating precompile statements... 3842 generated in 104.492933 seconds (overhead  67.737766 seconds)

After:

Generating precompile statements... 4393 generated in 133.891992 seconds (overhead  90.435911 seconds)

Not a huge problem maybe, but it did kind of surprise me.

@KristofferC KristofferC mentioned this pull request Sep 30, 2020
Merged
Keno pushed a commit that referenced this pull request Jun 5, 2024
@KristofferC @JeffBezanson
use precompile generation for Distributed instead of hardcoded list (#…
7eead92 
…33077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees

No one assigned

Labels

compiler:precompilation Precompilation of modules latency Latency parallelism Parallel or distributed computation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Precompile file for Distributed

3 participants

@KristofferC @JeffBezanson