fix #33338, race condition in triggering method compilation #33839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
force-pushed
the
jb/33338
branch
2 times, most recently
from
c44ab11 to
df1a3fc
Compare
vtjnash
approved these changes
Nov 14, 2019
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
set by some threads
Sounds like we should have a lock for this state also then (in jl_type_infer). This state is probably supposed to be single-threaded boot-strapping only, so it's useful to know that it can get in the way with threads as we improve this area.
JeffBezanson
force-pushed
the
jb/33338
branch
from
df1a3fc to
31597d9
Compare
Member
Looks like it, thanks! Backportable? |
KristofferC
pushed a commit
that referenced
this pull request
Nov 15, 2019
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be too heavy-handed, but I'll put it up as an RFC. It looks like it was possible for
mi->inInferenceand/orin_inferenceto be set by some threads, causing other threads to returnNULLfromjl_type_infer.@fredrikekre See if this fixes it for you.
There was also a random missing unlock.