Enhance methodswith #33883
Closed
Enhance methodswith #33883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
timholy
commented
Nov 19, 2019
| abstract type Super end | ||
| struct Sub <: Super end | ||
| abstract type SuperP{A<:AbstractArray} end | ||
| abstract type SubP{A<:AbstractVector} <: SuperP{A} end |
Member
Author
There was a problem hiding this comment.
Sadly, had I written SubP{A} <: SuperP{A} then the test would have failed. Presumably this is just #6383, but if there is a nice workaround I'd be happy to incorporate it. I am sure there's a lot of code out there that doesn't re-impose the same parameter bounds.
Member
Author
|
Do we want this for Julia 1.4? There seem to be a number of supportive reactions but it would be nice if this got some code review and a merge decision. |
Member
|
I'm fine with it. @JeffBezanson? Given that this is an interactive tool, I'm not overly concerned. |
Member
Author
|
I can achieve everything I need with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #33866. This pretty much does everything I need it to currently. It does not tackle the code comment, though it does essentially work around it via subtyping.