Support git credential helper resetting #35064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
added
libgit2
Member
Author
Member
Author
|
CI failures appear to be unrelated |
Member
Author
|
@ararslan could you review? I know everyone seems scared of LibGit2 changes but this one should be pretty easy to review |
ararslan
approved these changes
Mar 16, 2020
Member
ararslan
left a comment
ararslan
left a comment
There was a problem hiding this comment.
Looks good as far as I can tell. I assume the macOS failure is unrelated.
Member
Author
|
Accidentally closed the PR instead of merging... |
KristofferC
pushed a commit
that referenced
this pull request
Mar 23, 2020
(cherry picked from commit 0f1b119)
27 tasks
oxinabox
pushed a commit
to oxinabox/julia
that referenced
this pull request
Apr 8, 2020
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to libgit2 fixing an issue with iterator ordering and Julia now updating to a libgit2 release including that fix we now remove this fail safe.