speed up llvmcall unique name generation #35144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
compiler:codegen
vtjnash
reviewed
Mar 19, 2020
vtjnash
reviewed
Mar 19, 2020
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
This variable needs to go away (soon), but might as well use the existing name, so that we can grep for it.
JeffBezanson
force-pushed
the
jb/llvmcallnames
branch
from
d6ea11b to
2371e6c
Compare
KristofferC
pushed a commit
that referenced
this pull request
Mar 23, 2020
(cherry picked from commit 5d5f799)
27 tasks
KristofferC
pushed a commit
that referenced
this pull request
Mar 23, 2020
(cherry picked from commit 5d5f799)
oxinabox
pushed a commit
to oxinabox/julia
that referenced
this pull request
Apr 8, 2020
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up codegen of functions that use many duplicate llvmcalls, such as in LoopVectorization/SIMDPirates. From issue #35131
For me this takes the time to run the LoopVectorization tests from 5'40" to 5'15" (note this is a somewhat slow machine).