Skip to content

fix stackoverflow in circshift!(x, y, (1.0,)) #36734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

fix stackoverflow in circshift!(x, y, (1.0,)) #36734

merged 1 commit into from
Jul 23, 2020

Conversation

@rfourquet
Copy link
Member

@rfourquet rfourquet commented Jul 20, 2020

Currently:

julia> y = rand(2, 3); circshift(y, (1.0,))
2×3 Matrix{Float64}:
 0.224088  0.726063  0.704152
 0.545146  0.442787  0.417946

julia> x = similar(y); circshift!(x, y, (1.0,))
ERROR: StackOverflowError:

An alternative fix would be to disallow non-Integer, but would be (minorly?) breaking.

@rfourquet rfourquet added arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug labels Jul 20, 2020
@JeffBezanson JeffBezanson merged commit 773ef66 into master Jul 23, 2020
@JeffBezanson JeffBezanson deleted the rf/circshift-nonint branch July 23, 2020 23:15
@rfourquet rfourquet mentioned this pull request Jul 24, 2020
Merged
rfourquet added a commit that referenced this pull request Jul 24, 2020
@rfourquet
fix stackoverflow in circshift!(x, y, (1.0,)) (#36734)
5091177 
(cherry picked from commit 773ef66)
JeffBezanson pushed a commit that referenced this pull request Jul 25, 2020
@rfourquet @JeffBezanson
fix stackoverflow in circshift!(x, y, (1.0,)) (#36734)
75de80b 
(cherry picked from commit 773ef66)
@KristofferC KristofferC mentioned this pull request Aug 3, 2020
Merged
25 tasks
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
@rfourquet @simeonschaub
fix stackoverflow in circshift!(x, y, (1.0,)) (JuliaLang#36734)
e542198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees

No one assigned

Labels

arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rfourquet @JeffBezanson @KristofferC