- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.7k
fix some issues with buildbot path not updating in stacktraces / method errors #37427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    d4b722f    to
    7ae987b      
    Compare
  
    451ccda    to
    c997286      
    Compare
  
    | Any chance we could get this rebased ? | 
  This was referenced Dec 11, 2020 
      
| bump for 1.7. Though, being a bug in some sense it can be added in a patch release I guess. | 
6c3cafa    to
    401b073      
    Compare
  
    | yeah would love to have this in 1.7 too. | 
401b073    to
    f9b5108      
    Compare
  
    
              
                    vchuravy
  
              
              reviewed
              
                  
                    Oct 10, 2021 
                  
              
              
            
            
18dd08b    to
    b63d254      
    Compare
  
    | julia> rand(3) * rand(4,5)
ERROR: DimensionMismatch("A has dimensions (3,1) but B has dimensions (4,5)")
Stacktrace:
 [1] gemm_wrapper!(C::Matrix{Float64}, tA::Char, tB::Char, A::Matrix{Float64}, B::Matrix{Float64}, _add::LinearAlgebra.MulAddMul{true, true, Bool, Bool})
   @ LinearAlgebra ~/Downloads/julia-b63d254566/share/julia/stdlib/v1.8/LinearAlgebra/src/matmul.jl:590
 [2] mul!
   @ ~/Downloads/julia-b63d254566/share/julia/stdlib/v1.8/LinearAlgebra/src/matmul.jl:149 [inlined]
 [3] mul!
   @ ~/Downloads/julia-b63d254566/share/julia/stdlib/v1.8/LinearAlgebra/src/matmul.jl:255 [inlined]
 [4] *
   @ ~/Downloads/julia-b63d254566/share/julia/stdlib/v1.8/LinearAlgebra/src/matmul.jl:140 [inlined]
 [5] *(a::Vector{Float64}, B::Matrix{Float64})
   @ LinearAlgebra ~/Downloads/julia-b63d254566/share/julia/stdlib/v1.8/LinearAlgebra/src/matmul.jl:57
 [6] top-level scope
   @ REPL[1]:1🎉 | 
      
        
      
      
  
    84 tasks
  
    
  LilithHafner 
      pushed a commit
        to LilithHafner/julia
      that referenced
      this pull request
    
      Feb 22, 2022 
    
    
  
    
  LilithHafner 
      pushed a commit
        to LilithHafner/julia
      that referenced
      this pull request
    
      Mar 8, 2022 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    backport 1.6
  Change should be backported to release-1.6 
  
    error messages
  Better, more actionable error messages 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes #35191
Closes #36216
Closes #35890