Skip to content

Switch to LLVM ORC v2 #38008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 8, 2020
Merged

Switch to LLVM ORC v2 #38008

merged 5 commits into from
Dec 8, 2020

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 13, 2020

Mostly pretty mechanical. Some old hacks went away. Result seems to work, so is presumably good?

@vtjnash vtjnash requested a review from vchuravy October 13, 2020 14:33
@vchuravy
Copy link
Member

vchuravy commented Oct 19, 2020

And OrcV1 is gone: http://lists.llvm.org/pipermail/llvm-dev/2020-October/145866.html

@vtjnash
Copy link
Member Author

vtjnash commented Nov 17, 2020 •
edited
Loading

remaining tasks are:

  • switch back to eager finalization (our cgmemmgr doesn't support interleaving of finalization), to address macos64 build failure
  • figure out symbol conflict from exporting function aliases
  • figure out why win32 and win64 aren't respecting the -elf triple

@vchuravy
Copy link
Member

vchuravy commented Nov 17, 2020

figure out why win32 and win64 aren't respecting the -elf triple

In LLVM.jl I had to normalize the triple before passing it to target https://github.com/maleadt/LLVM.jl/blob/b0780fa710219b1ca2e0a418d5dc82fa6dfafe71/src/orc.jl#L130-L134

@vtjnash
Copy link
Member Author

vtjnash commented Nov 17, 2020

I suppose, but we don't usually like the default triple, and the process triple that we use appears to already call normalize: https://llvm.org/doxygen/Host_8cpp_source.html#l01545

@vtjnash vtjnash force-pushed the jn/orcv2 branch 2 times, most recently from 699482d to 94bd2b8 Compare November 28, 2020 17:23
@vtjnash vtjnash marked this pull request as ready for review November 28, 2020 20:29
vchuravy
vchuravy approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tried this on PPC as well.

Let's squash and GTM?

vchuravy
vchuravy reviewed Dec 6, 2020
View reviewed changes
@vchuravy vchuravy mentioned this pull request Dec 6, 2020
Closed
vchuravy
vchuravy reviewed Dec 6, 2020
View reviewed changes
vtjnash and others added 5 commits December 7, 2020 22:28
@vtjnash @vchuravy
llvm: switch from assert to cantFail
9f801ea 
Ensures that this usage is proper even if using an LLVM assertions
build, but not using FORCE_ASSERTIONS=1 in Julia
@vtjnash @vchuravy
LLVM: switch to Orc v2 API
2d178e4 
This should not be a user-visible change, but should prepare us for
being able to use new APIs (the legacy ones are deleted now on LLVM
master / v12).
@vtjnash @vchuravy
cmake,LLVM: better xcross configuration
ad6f14f 
DRY some variables, and pass others along better
@vchuravy
ExecutionSession no longer takes VModuleKey
b8c5da1
@vchuravy
Let Orc handle JITEventListerners
ef84df1
@vchuravy vchuravy merged commit 30d309a into master Dec 8, 2020
@vchuravy vchuravy deleted the jn/orcv2 branch December 8, 2020 05:13
@maleadt maleadt mentioned this pull request Dec 8, 2020
Closed
Keno pushed a commit that referenced this pull request Dec 9, 2020
@vtjnash
Revert "Switch to LLVM ORC v2" #38008 (#38785)
599d329 
* Revert "Let Orc handle JITEventListerners"

This reverts commit ef84df1.

* Revert "ExecutionSession no longer takes VModuleKey"

This reverts commit b8c5da1.

* Revert "LLVM: switch to Orc v2 API"

This reverts commit 2d178e4.
vtjnash added a commit that referenced this pull request Dec 9, 2020
@vtjnash
Switch back to LLVM ORC v2, take two
3648ad1 
Refs #38008 & #38785

(This reverts commit 599d329.)
@vtjnash vtjnash mentioned this pull request Dec 9, 2020
Merged
vtjnash added a commit that referenced this pull request Dec 10, 2020
@vtjnash
Switch back to LLVM ORC v2, take two
8460b7f 
Refs #38008 & #38785

(This reverts commit 599d329.)
vtjnash added a commit that referenced this pull request Dec 12, 2020
@vtjnash
Switch back to LLVM ORC v2, take two
085e463 
Refs #38008 & #38785

(This reverts commit 599d329.)
vtjnash added a commit that referenced this pull request Dec 17, 2020
@vtjnash
Switch back to LLVM ORC v2, take two
a168de7 
Refs #38008 & #38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)
vtjnash added a commit that referenced this pull request Dec 17, 2020
@vtjnash
Switch back to LLVM ORC v2, take two (#38804)
fad55ab 
Refs #38008 & #38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)
KristofferC pushed a commit that referenced this pull request Dec 19, 2020
@vtjnash @KristofferC
Switch back to LLVM ORC v2, take two (#38804)
06171f6 
Refs #38008 & #38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)

(cherry picked from commit fad55ab)
staticfloat pushed a commit that referenced this pull request Jan 15, 2021
@vtjnash @staticfloat
Switch back to LLVM ORC v2, take two (#38804)
8a3ab25 
Refs #38008 & #38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)

(cherry picked from commit fad55ab)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@vtjnash @ElOceanografo
Revert "Switch to LLVM ORC v2" JuliaLang#38008 (JuliaLang#38785)
6f66e47 
* Revert "Let Orc handle JITEventListerners"

This reverts commit ef84df1.

* Revert "ExecutionSession no longer takes VModuleKey"

This reverts commit b8c5da1.

* Revert "LLVM: switch to Orc v2 API"

This reverts commit 2d178e4.
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@vtjnash @ElOceanografo
Switch back to LLVM ORC v2, take two (JuliaLang#38804)
79cdf71 
Refs JuliaLang#38008 & JuliaLang#38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vtjnash @staticfloat
Switch back to LLVM ORC v2, take two (#38804)
63d4661 
Refs #38008 & #38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)

(cherry picked from commit fad55ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vchuravy vchuravy vchuravy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtjnash @vchuravy