Avoid allocation in ldiv! with QR #38389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ldiv!` is currently allocating memory unnecessarily: ```julia julia> n = 1000; A = randn(n,n); F = qr(A); b = randn(n); julia> @time ldiv!(F, b); 0.005001 seconds (9 allocations: 7.637 MiB) ``` The culprit is that `F.R` creates a copy. Using `UpperTriangular(F.factors)` is equivalent to `F.R` without the allocations.
dkarrasch
reviewed
Nov 11, 2020
Co-authored-by: Daniel Karrasch <[email protected]>
Co-authored-by: Daniel Karrasch <[email protected]>
dkarrasch
reviewed
Nov 11, 2020
Co-authored-by: Daniel Karrasch <[email protected]>
dkarrasch
approved these changes
Nov 12, 2020
|
Let's rerun CI and merge if tests pass. |
dkarrasch
added
merge me
Keno
reviewed
Dec 9, 2020
| ldiv!(UpperTriangular(view(R,1:n,:)), view(B, 1:n, :)) | ||
| return B | ||
| end | ||
| function ldiv!(A::QR, B::StridedVector) |
There was a problem hiding this comment.
This duplicates the method just below it. #38801
KristofferC
pushed a commit
that referenced
this pull request
Dec 11, 2020
Co-authored-by: Daniel Karrasch <[email protected]> (cherry picked from commit b1a2847)
KristofferC
pushed a commit
that referenced
this pull request
Dec 11, 2020
|
Apologies: I think it was a result as rebase-gone-bad. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Co-authored-by: Daniel Karrasch <[email protected]>
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reopens #31314 after a dodgy rebase