Skip to content

Conversation

@simonbyrne
Copy link
Member

Fixes #9826.

A quick benchmark:

julia> X = [big(rand(1:10000)) // big(rand(1:10000)) for i = 1:100, j = 1:100];

julia> @time X*X; # before
 12.525924 seconds (45.29 M allocations: 1.267 GiB, 8.44% gc time)

julia> @time X*X; # after
  2.343117 seconds (18.95 M allocations: 733.016 MiB, 18.66% gc time, 17.26% compilation time)

@simonbyrne simonbyrne added bignums BigInt and BigFloat rationals The Rational type and values thereof labels Nov 30, 2020
@JeffBezanson JeffBezanson added the performance Must go faster label Nov 30, 2020
@JeffBezanson JeffBezanson merged commit 217a449 into master Nov 30, 2020
@JeffBezanson JeffBezanson deleted the sb/mpq branch November 30, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bignums BigInt and BigFloat performance Must go faster rationals The Rational type and values thereof

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exploit mpq functions for Rational{BigInt}?

4 participants