Skip to content

[LibCURL]: Reconcile BB and from-source configuration of LibCURL. #38796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2020
Merged

[LibCURL]: Reconcile BB and from-source configuration of LibCURL. #38796

merged 1 commit into from
Dec 9, 2020

Conversation

@staticfloat
Copy link
Member

@staticfloat staticfloat commented Dec 9, 2020

We switched away from using MbedTLS on all platforms to use the native
TLS libraries on Windows/MacOS; let's ensure that a from-source build
does the same here as well.

@staticfloat
[LibCURL]: Reconcile BB and from-source configuration of LibCURL.
cfe9d60 
We switched away from using MbedTLS on all platforms to use the native
TLS libraries on Windows/MacOS; let's ensure that a from-source build
does the same here as well.
@staticfloat staticfloat added the backport 1.6 Change should be backported to release-1.6 label Dec 9, 2020
@staticfloat
Copy link
Member Author

staticfloat commented Dec 9, 2020

The flags are matching what is defined here: https://github.com/JuliaPackaging/Yggdrasil/blob/a9ef14d0ca0bbd55210597d1607d582af79a2b21/L/LibCURL/build_tarballs.jl#L18-L48

StefanKarpinski
StefanKarpinski approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Keno Keno merged commit b407c5a into master Dec 9, 2020
@Keno Keno deleted the sf/curl_tls_source_configuration branch December 9, 2020 22:31
KristofferC pushed a commit that referenced this pull request Dec 11, 2020
@staticfloat @KristofferC
[LibCURL]: Reconcile BB and from-source configuration of LibCURL. (#3…
9f73f05 
…8796)

We switched away from using MbedTLS on all platforms to use the native
TLS libraries on Windows/MacOS; let's ensure that a from-source build
does the same here as well.

(cherry picked from commit b407c5a)
@KristofferC KristofferC mentioned this pull request Dec 11, 2020
Merged
53 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 19, 2020
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@staticfloat @ElOceanografo
[LibCURL]: Reconcile BB and from-source configuration of LibCURL. (Ju…
95ef49f 
…liaLang#38796)

We switched away from using MbedTLS on all platforms to use the native
TLS libraries on Windows/MacOS; let's ensure that a from-source build
does the same here as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@staticfloat @StefanKarpinski @KristofferC @Keno