-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Restore the version information for libjulia.dylib #38829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the version information for libjulia.dylib #38829
Conversation
|
Note that even with this, there are troubles: |
|
Needs the backport label. |
|
@vtjnash do you have any insight into whether |
|
Why not |
|
It's not that I want to add these linker commands, it's that they get added as a side-effect of the other flags that are added to |
|
Besides all that, even with this PR, I can't use various JLLs which access libjulia.dylib (linked at build time via libjulia_jll) because references to e.g. This affects e.g. CxxWrap.jl which as a result is broken for me in 1.6 / 1.7 (CC @barche) |
|
Of course the answer to that might be to create a libjulia_jll 1.6, and rebuild all JLLs using libjulia_jll to also have a 1.6 variant. But it'd be much nicer if one could use the same binaries for 1.5 and 1.6... |
|
I don't really understand what changed here, but from Julia 1.6 on we can have |
Fixes #38782
This is a bit of a hack, but seems to work on my Mac, but I have not yet tested this on other operating systems. The main question is whether the other non-empty value for
JLIBLDFLAGS, namely-Wl,-Bsymbolic-functions, which is used on Linux systems if the linker there supports it. I have no idea what this does; in particular, I don't know if setting it here ...CC @staticfloat