Update dimension checks in symtridiag eigen calls #38833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
reviewed
Dec 11, 2020
| @test_throws DimensionMismatch LAPACK.stebz!('A','B',zero(elty),zero(elty),0,0,-1.,d,rand(elty,10)) | ||
| @test_throws DimensionMismatch LAPACK.stegr!('N','A',d,rand(elty,11),zero(elty),zero(elty),0,0) | ||
| @test_throws DimensionMismatch LAPACK.stein!(d,zeros(elty,10),zeros(elty,10),zeros(BlasInt,10),zeros(BlasInt,10)) | ||
| @test_throws DimensionMismatch LAPACK.stein!(d,zeros(elty,11),zeros(elty,10),zeros(BlasInt,10),zeros(BlasInt,10)) |
Member
There was a problem hiding this comment.
It would be good to also have positive tests, so that this functionality cannot regress in the future. Like have an example where both dv and ev have the same length, and then call eigen, eigvals etc. on them. For simplicity, you could choose ev = zeros(eltype(dv), length(dv)), then you have the eigenvalues on the diagonal, and you can check the numerical values easily.
Co-authored-by: Daniel Karrasch <[email protected]>
Member
|
bump. apparently just needs a quick test? |
Member
|
bump? |
Contributor
Author
|
Thank you @dkarrasch, and sorry for dropping the ball on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #38793, addressing comment JuliaLang/LinearAlgebra.jl#796. The motivation is to fix a small inconsistency between the
SymTridiagonaltype and admissible calls toeigen/eigen!for that type.In
master, theSymTridiagonalconstructor allows the superdiagonal vector (ev) to be of length eithernorn-1(wherenis the length of the main diagonal), but some calls to LAPACK eigensolvers which dispatch onSymTridiagonalthrougheigen/eigen!are stricter, only allowingevto have dimensionn-1.CC @dkarrasch