Force-specialize on T in cat_similar
#39292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are tiny (quick to compile), call methods that force-specialize on `T`, and are called by methods that force-specialize on `T`. Consequently, there does not seem to be any good reason to lose inferrability in these methods.
Sacha0
approved these changes
Jan 17, 2021
timholy
added a commit
that referenced
this pull request
Jan 19, 2021
The `cat` pipeline has long had poor inferrability. Together with #39292 and #39294, this should basically put an end to that problem. Together, at least in simple cases these make the performance of `cat` essentially equivalent to the manual version. In other words, the `test1` and `test2` of #21673 benchmark very similarly.
This was referenced Jan 19, 2021
timholy
added a commit
that referenced
this pull request
Jan 20, 2021
The `cat` pipeline has long had poor inferrability. Together with #39292 and #39294, this should basically put an end to that problem. Together, at least in simple cases these make the performance of `cat` essentially equivalent to the manual version. In other words, the `test1` and `test2` of #21673 benchmark very similarly.
KristofferC
pushed a commit
that referenced
this pull request
Jan 20, 2021
These methods are tiny (quick to compile), call methods that force-specialize on `T`, and are called by methods that force-specialize on `T`. Consequently, there does not seem to be any good reason to lose inferrability in these methods. (cherry picked from commit 33573ec)
KristofferC
pushed a commit
that referenced
this pull request
Jan 20, 2021
The `cat` pipeline has long had poor inferrability. Together with #39292 and #39294, this should basically put an end to that problem. Together, at least in simple cases these make the performance of `cat` essentially equivalent to the manual version. In other words, the `test1` and `test2` of #21673 benchmark very similarly. (cherry picked from commit 78d55e2)
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2021
These methods are tiny (quick to compile), call methods that force-specialize on `T`, and are called by methods that force-specialize on `T`. Consequently, there does not seem to be any good reason to lose inferrability in these methods. (cherry picked from commit 33573ec)
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2021
The `cat` pipeline has long had poor inferrability. Together with #39292 and #39294, this should basically put an end to that problem. Together, at least in simple cases these make the performance of `cat` essentially equivalent to the manual version. In other words, the `test1` and `test2` of #21673 benchmark very similarly. (cherry picked from commit 78d55e2)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
These methods are tiny (quick to compile), call methods that force-specialize on `T`, and are called by methods that force-specialize on `T`. Consequently, there does not seem to be any good reason to lose inferrability in these methods.
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
The `cat` pipeline has long had poor inferrability. Together with JuliaLang#39292 and JuliaLang#39294, this should basically put an end to that problem. Together, at least in simple cases these make the performance of `cat` essentially equivalent to the manual version. In other words, the `test1` and `test2` of JuliaLang#21673 benchmark very similarly.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
These methods are tiny (quick to compile), call methods that force-specialize on `T`, and are called by methods that force-specialize on `T`. Consequently, there does not seem to be any good reason to lose inferrability in these methods.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
The `cat` pipeline has long had poor inferrability. Together with JuliaLang#39292 and JuliaLang#39294, this should basically put an end to that problem. Together, at least in simple cases these make the performance of `cat` essentially equivalent to the manual version. In other words, the `test1` and `test2` of JuliaLang#21673 benchmark very similarly.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
These methods are tiny (quick to compile), call methods that force-specialize on `T`, and are called by methods that force-specialize on `T`. Consequently, there does not seem to be any good reason to lose inferrability in these methods. (cherry picked from commit 33573ec)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
The `cat` pipeline has long had poor inferrability. Together with #39292 and #39294, this should basically put an end to that problem. Together, at least in simple cases these make the performance of `cat` essentially equivalent to the manual version. In other words, the `test1` and `test2` of #21673 benchmark very similarly. (cherry picked from commit 78d55e2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are tiny (quick to compile), call methods
that force-specialize on
T, and are called by methodsthat force-specialize on
T. Consequently, there does notseem to be any good reason to lose inferrability in these methods.