-
-
Couldn't load subscription status.
- Fork 5.7k
Don't touch gvars when compiling for an external back-end. #39387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| F->setPersonalityFn(juliapersonality_func); | ||
| // Add unwind exception personalities to functions to handle async exceptions | ||
| if (Function *F = dyn_cast<Function>(&G)) | ||
| F->setPersonalityFn(juliapersonality_func); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Means backends will have to initialize the personality functions themselves, but I suspect that's okay.
Co-authored-by: Julian Samaroo <[email protected]>
|
CI failures unrelated (Profile, timeout). |
|
Might have been good to squash. |
|
Ah, of course... 🤦♂️ |
I noticed in JuliaGPU/CUDA.jl#552 that exported global variables in an
llvmcallgot internalized along the way:It seems like this functionality should not trigger when compiling for an external compiler back-end.
FWIW, regular
@code_llvmdoes not trigger this conversion, so just doing@code_llvm dump_module=true main()still results in: