Skip to content

Include address in opaque method's show output #39780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Include address in opaque method's show output #39780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions base/methodshow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ function sym_to_string(sym)
end

function show(io::IO, m::Method)
is_opaque_closure_method(m) && return show_method_with_pointer(io, m)
tv, decls, file, line = arg_decl_parts(m)
sig = unwrap_unionall(m.sig)
if sig === Tuple
Expand Down Expand Up @@ -297,6 +298,17 @@ end
show(io::IO, ms::MethodList) = show_method_table(io, ms)
show(io::IO, mt::Core.MethodTable) = show_method_table(io, MethodList(mt))

function is_opaque_closure_method(m::Method)
sig = unwrap_unionall(m.sig)
return sig === Tuple && m.name === Symbol("opaque closure")
# ASK: what is the proper way to detect opaque closure?
end

function show_method_with_pointer(io::IO, m::Method)
hexstr = string(UInt(pointer_from_objref(m)), base = 16, pad = Sys.WORD_SIZE>>2)
print(io, m.name, " @0x", hexstr, " in ", m.module)
end

function inbase(m::Module)
if m == Base
true
Expand Down
3 changes: 3 additions & 0 deletions test/opaque_closure.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@ mk_va_opaque() = @opaque (x...)->x
# OpaqueClosure show method
@test repr(@opaque x->1) == "(::Any)::Any->◌"

# Opaque closure method show method
@test contains(repr((@opaque x->1).source), "opaque closure @0x")

# Opaque closure in CodeInfo returned from generated functions
function mk_ocg(args...)
ci = @code_lowered const_int()
Expand Down