Fix reduced_index for Integer UnitRanges having eltypes other than Int #39999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
approved these changes
Mar 12, 2021
jishnub
changed the title
|
This also fixes some other reductions that use non- Before (using the 32-bit build of Julia): julia> Int
Int32
julia> reduce(+, Int64(5):Int64(6), dims = 1)
ERROR: TypeError: in typeassert, expected Tuple{Base.OneTo{Int64}}, got a value of type Tuple{Base.OneTo{Int32}}After: julia> reduce(+, Int64(5):Int64(6), dims = 1)
1-element Array{Int64,1}:
11 |
|
Is this good to go? |
|
Yes, this is ready |
johnnychen94
approved these changes
Apr 14, 2021
|
Gentle bump, would be nice to have this fixed |
Co-authored-by: Simeon Schaub <[email protected]>
simeonschaub
approved these changes
Apr 28, 2021
simeonschaub
added
bugfix
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
JuliaLang#39999) * reduced_index for BigInt UnitRanges * Add tests for Integer subtypes * use OneTo constructor instead of typeof Co-authored-by: Simeon Schaub <[email protected]> Co-authored-by: Simeon Schaub <[email protected]>
jarlebring
pushed a commit
to jarlebring/julia
that referenced
this pull request
May 4, 2021
JuliaLang#39999) * reduced_index for BigInt UnitRanges * Add tests for Integer subtypes * use OneTo constructor instead of typeof Co-authored-by: Simeon Schaub <[email protected]> Co-authored-by: Simeon Schaub <[email protected]>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
JuliaLang#39999) * reduced_index for BigInt UnitRanges * Add tests for Integer subtypes * use OneTo constructor instead of typeof Co-authored-by: Simeon Schaub <[email protected]> Co-authored-by: Simeon Schaub <[email protected]>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
JuliaLang#39999) * reduced_index for BigInt UnitRanges * Add tests for Integer subtypes * use OneTo constructor instead of typeof Co-authored-by: Simeon Schaub <[email protected]> Co-authored-by: Simeon Schaub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39995
Now