Skip to content

Fix eigvals(:::SymTridiagonal) with longer off-diagonal vector #40165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 11, 2021
Merged

Fix eigvals(:::SymTridiagonal) with longer off-diagonal vector #40165

merged 5 commits into from
Apr 11, 2021

Conversation

@dlfivefifty
Copy link
Contributor

@dlfivefifty dlfivefifty commented Mar 24, 2021

This resolves #40154

@dlfivefifty
Copy link
Contributor Author

dlfivefifty commented Mar 24, 2021

Note eigen was already fixed here: dlfivefifty@ad523d5

@dkarrasch dkarrasch added the linear algebra Linear algebra label Mar 24, 2021
@dkarrasch dkarrasch added the merge me PR is reviewed. Merge when all tests are passing label Mar 24, 2021
@vtjnash vtjnash removed the merge me PR is reviewed. Merge when all tests are passing label Apr 2, 2021
@vtjnash
Copy link
Member

vtjnash commented Apr 2, 2021

Appears we cannot merge due to test failurs

dkarrasch
dkarrasch reviewed Apr 7, 2021
View reviewed changes
stdlib/LinearAlgebra/src/lapack.jl Outdated
chkstride1(dv, ev)
n = length(dv)
if length(ev) != n - 1 && length(ev) != n
if length(ev) != n - 1 || length(ev) != n
Copy link
Member

@dkarrasch dkarrasch Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the && was correct.

Copy link
Contributor Author

@dlfivefifty dlfivefifty Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah sorry

@dkarrasch
Copy link
Member

dkarrasch commented Apr 7, 2021

The previous issue was that

julia/stdlib/LinearAlgebra/test/lapack.jl

Line 410 in 8218480

@test_throws DimensionMismatch LAPACK.stev!('U',d,rand(elty,10))

no longer threw a DimensionMismatch error, so the 10 should be replaced by 11, or the test removed entirely.

@andreasnoack andreasnoack merged commit 5b7f4c5 into JuliaLang:master Apr 11, 2021
@dkarrasch dkarrasch changed the title Fix eigvals(:::SymTridagonal) with longer off-diagonal vector Fix eigvals(:::SymTridiagonal) with longer off-diagonal vector Apr 19, 2021
@dkarrasch dkarrasch mentioned this pull request Apr 19, 2021
Merged
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@dlfivefifty @ElOceanografo
Fix eigvals(:::SymTridagonal) with longer off-diagonal vector (JuliaL…
29ac2eb 
…ang#40165)

* Fix eigvals(:::SymTridagonal) with longer off-diagonal vector

* Update tridiag.jl

* Update lapack.jl

* Revert "Update lapack.jl"

This reverts commit 5c40476.

* Update lapack.jl
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@dlfivefifty @antoine-levitt
Fix eigvals(:::SymTridagonal) with longer off-diagonal vector (JuliaL…
e6da235 
…ang#40165)

* Fix eigvals(:::SymTridagonal) with longer off-diagonal vector

* Update tridiag.jl

* Update lapack.jl

* Revert "Update lapack.jl"

This reverts commit 5c40476.

* Update lapack.jl
@KristofferC KristofferC added the backport 1.6 Change should be backported to release-1.6 label Jun 11, 2021
KristofferC pushed a commit that referenced this pull request Jun 11, 2021
@dlfivefifty @KristofferC
Fix eigvals(:::SymTridagonal) with longer off-diagonal vector (#40165)
531255a 
(cherry picked from commit 5b7f4c5)
KristofferC pushed a commit that referenced this pull request Jun 11, 2021
@dlfivefifty @KristofferC
Fix eigvals(:::SymTridagonal) with longer off-diagonal vector (#40165)
6d74a23 
(cherry picked from commit 5b7f4c5)
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@dlfivefifty @johanmon
Fix eigvals(:::SymTridagonal) with longer off-diagonal vector (JuliaL…
b8aca7a 
…ang#40165)

* Fix eigvals(:::SymTridagonal) with longer off-diagonal vector

* Update tridiag.jl

* Update lapack.jl

* Revert "Update lapack.jl"

This reverts commit 5c40476.

* Update lapack.jl
@KristofferC KristofferC mentioned this pull request Jul 12, 2021
Merged
75 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@dlfivefifty @staticfloat
Fix eigvals(:::SymTridagonal) with longer off-diagonal vector (#40165)
4913a26 
(cherry picked from commit 5b7f4c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees

No one assigned

Labels

linear algebra Linear algebra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eigvals(::SymTridiagonal) errors if off-diagonal has wrong length

5 participants

@dlfivefifty @vtjnash @dkarrasch @andreasnoack @KristofferC