Skip to content

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Apr 8, 2021

We generally seem to prefer sentences over keyword lists (which feel a bit too much like Javadoc to me), so this changes the documentation to use a more free-form sentence for "see also," including an ending period. Vote now? 👍 👎

We seem to intuitively have preferred this already, by a ratio of 5:2:

$ grep -RI 'See also:' base/ | wc -l
      48
$ grep -RI 'See also' base/ | wc -l
     167 # diff = 119

@mbauman mbauman added the docs This change adds or pertains to documentation label Apr 8, 2021
@mcabbott
Copy link
Contributor

mcabbott commented Apr 9, 2021

To make the counter-argument: Some are complete sentences to read, while others are just a list which you should not try to pronounce. If the second are consistently marked with a colon then perhaps that's useful hint not to hope for a grammatical sentence.

Or, if the colons are removed, then perhaps many lists should have an "and" before the last?

@vtjnash
Copy link
Member Author

vtjnash commented Apr 9, 2021

A colon should not change whether content can be read, or whether a list has an 'and' (perhaps just me, but I mentally add an 'etc' to any list that doesn't have an and/or to make it grammatical)

@vtjnash
Copy link
Member Author

vtjnash commented Apr 21, 2021

@StefanKarpinski Since you're the main dissenting voice, in your opinion, do you suggest that we (a) keep the status quo (b) convert mostly in the other direction or (c) other?

@vtjnash vtjnash requested a review from StefanKarpinski May 4, 2021 19:05
@vtjnash vtjnash added the triage This should be discussed on a triage call label May 4, 2021
convenience since decimal literals are converted to `Float64` when parsed, so
`BigFloat(2.1)` may not yield what you expect.
See also:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to clarify: is the proposed style to use the colon at the start of a multi-line list, but not otherwise?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in this case, it felt more grammatical with the colon because it is a multiline list.

@oscardssmith oscardssmith removed the triage This should be discussed on a triage call label May 27, 2021
We generally seem to prefer sentences over keyword lists (which feel a
bit too much like Javadoc to me), so this changes the documentation to
use a more free-form sentence for "see also," including an ending period
(we seem to have intuitively preferred this already, by a ratio of 5:2).
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label May 27, 2021
@vtjnash vtjnash merged commit 93d375c into master May 28, 2021
@vtjnash vtjnash deleted the jn/see-also branch May 28, 2021 19:19
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label May 29, 2021
shirodkara pushed a commit to shirodkara/julia that referenced this pull request Jun 9, 2021
We generally seem to prefer sentences over keyword lists (which feel a
bit too much like Javadoc to me), so this changes the documentation to
use a more free-form sentence for "see also," including an ending period
(we seem to have intuitively preferred this already, by a ratio of 5:2).
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
We generally seem to prefer sentences over keyword lists (which feel a
bit too much like Javadoc to me), so this changes the documentation to
use a more free-form sentence for "see also," including an ending period
(we seem to have intuitively preferred this already, by a ratio of 5:2).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This change adds or pertains to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants