Explicit test that shuffle! behaves correct on BitArrays
#40558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasonProtter
changed the title
shuffle! behaves correct on BitArrays
MasonProtter
changed the title
shuffle! behaves correct on BitArraysshuffle! behaves correct on BitArrays
dkarrasch
reviewed
Apr 22, 2021
kshyatt
added
randomness
|
What are the odds this fails? |
|
Should be zero because I set the random number generator explicitly, but I just ran the test |
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone asked a question on Slack recently and my answer involved using
shuffle!on aBitMatrix. I ran the code a few times and the bits ended up in the bottom right of the matrix each time which freaked me out, but then I did an actual statistical test and found that it was a fluke.@StefanKarpinski suggested that I might as well stick it in the testsuite as a regression test, so here is that PR.