Add tests to make sure that Base.project_names, Base.manifest_names, Base.preferences_names, and Artifacts.artifact_names always have the same length
#40618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
changed the title
project_names, manifest_names, and preferences_names are in syncBase.project_names, Base.manifest_names, Base.preferences_names, and Artifacts.artifact_names always have the same length
…s`, `Base.preferences_names`, and `Artifacts.artifact_names` always have the same length
DilumAluthge
force-pushed
the
dpa/add-test-manifest-names
branch
from
b76f135 to
4abb6a3
Compare
staticfloat
approved these changes
Apr 27, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…s`, `Base.preferences_names`, and `Artifacts.artifact_names` always have the same length (JuliaLang#40618) * Add tests to make sure that `Base.project_names`, `Base.manifest_names`, `Base.preferences_names`, and `Artifacts.artifact_names` always have the same length * Add a comment explaining why we have these tests
jarlebring
pushed a commit
to jarlebring/julia
that referenced
this pull request
May 4, 2021
…s`, `Base.preferences_names`, and `Artifacts.artifact_names` always have the same length (JuliaLang#40618) * Add tests to make sure that `Base.project_names`, `Base.manifest_names`, `Base.preferences_names`, and `Artifacts.artifact_names` always have the same length * Add a comment explaining why we have these tests
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…s`, `Base.preferences_names`, and `Artifacts.artifact_names` always have the same length (JuliaLang#40618) * Add tests to make sure that `Base.project_names`, `Base.manifest_names`, `Base.preferences_names`, and `Artifacts.artifact_names` always have the same length * Add a comment explaining why we have these tests
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…s`, `Base.preferences_names`, and `Artifacts.artifact_names` always have the same length (JuliaLang#40618) * Add tests to make sure that `Base.project_names`, `Base.manifest_names`, `Base.preferences_names`, and `Artifacts.artifact_names` always have the same length * Add a comment explaining why we have these tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is code in Pkg.jl that assumes that the following tuples always have the same length:
Base.project_namesBase.manifest_namesBase.preferences_namesArtifacts.artifact_namesSo we should have tests to make sure that this always stays the case.