Add compat to docstring for single-arg isapprox
#40659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome and thanks for the contribution! Just one small suggestion for the terminology, but looks otherwise good to me. |
Co-authored-by: Simeon Schaub <[email protected]>
|
Thanks, good catch! |
simeonschaub
approved these changes
Apr 30, 2021
simeonschaub
added
docs
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Co-authored-by: Simeon Schaub <[email protected]>
jarlebring
pushed a commit
to jarlebring/julia
that referenced
this pull request
May 4, 2021
Co-authored-by: Simeon Schaub <[email protected]>
jarlebring
pushed a commit
to jarlebring/julia
that referenced
this pull request
May 6, 2021
Co-authored-by: Simeon Schaub <[email protected]>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
Co-authored-by: Simeon Schaub <[email protected]>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Co-authored-by: Simeon Schaub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This single-arg version was added in ab5b40a which first appeared in 1.5