Skip to content

Add ndims for AbstractArray types with an unspecified eltype #40682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2021
Merged

Add ndims for AbstractArray types with an unspecified eltype #40682

merged 1 commit into from
May 3, 2021

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented May 2, 2021

Currently

julia> ndims(Vector{Int})
1

julia> ndims(Vector)
ERROR: MethodError: no method matching ndims(::Type{Vector})

After this PR:

julia> ndims(Vector)
1

fredrikekre
fredrikekre reviewed May 3, 2021
View reviewed changes
test/abstractarray.jl
@test reverse(Diagonal([]),dims=1) == Diagonal([])
end

@testset "ndims and friends" begin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like ndims doesn't have any friends.

@fredrikekre fredrikekre merged commit b3b9aa0 into JuliaLang:master May 3, 2021
@jishnub jishnub deleted the ndimsAbsArray branch May 3, 2021 09:08
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@jishnub @ElOceanografo
ndims for AbstractArray{<:Any,N} (JuliaLang#40682)
2ceaad7
jarlebring pushed a commit to jarlebring/julia that referenced this pull request May 4, 2021
@jishnub @jarlebring
ndims for AbstractArray{<:Any,N} (JuliaLang#40682)
8bf2fcb
jarlebring pushed a commit to jarlebring/julia that referenced this pull request May 6, 2021
@jishnub @jarlebring
ndims for AbstractArray{<:Any,N} (JuliaLang#40682)
65042eb
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@jishnub @antoine-levitt
ndims for AbstractArray{<:Any,N} (JuliaLang#40682)
d020f15
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@jishnub @johanmon
ndims for AbstractArray{<:Any,N} (JuliaLang#40682)
1155408
This was referenced Mar 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jishnub @fredrikekre