Added check_open(sock) to _sockname to prevent segfault and throw error instead #41000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t checking could lead to a segfault on closed TCPSockets, see JuliaLang#40993
vtjnash
reviewed
May 31, 2021
Co-authored-by: Jameson Nash <[email protected]>
vtjnash
approved these changes
May 31, 2021
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
Not checking could lead to a segfault on closed TCPSockets in getpeername Fixes JuliaLang#40993
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Not checking could lead to a segfault on closed TCPSockets in getpeername Fixes JuliaLang#40993
ghost
mentioned this pull request
KristofferC
pushed a commit
that referenced
this pull request
Jan 10, 2022
50 tasks
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_sockname is used in getpeername in the Sockets module. Trying to use this with a closed socket would cause a segfault. The function now has check_open(sock) to check whether the socket is already closed and throw an error instead. Referenced in #40993