Skip to content

Conversation

@ArunS-tack
Copy link
Contributor

updated diagonal.jl to relax eltype for ldiv! and rdiv! methods as suggested by @dkarrasch (#40942 (comment)).

ref: JuliaLang/LinearAlgebra.jl#849 , #40942

@dkarrasch dkarrasch added the linear algebra Linear algebra label May 31, 2021
@dkarrasch
Copy link
Member

These methods are probably rarely used (adjoint(D::Diagonal) returns a Diagonal, not an Adjoint{Diagonal}), but we should test this generalization anyway, perhaps along the lines of

A = rand(3,3)
for trans in (identity, Adjoint, Transpose)
    @test ldiv!(trans(I(3)), A) == A
    @test rdiv!(A, trans(I(3))) == A
end

@dkarrasch dkarrasch merged commit 1a2285b into JuliaLang:master May 31, 2021
@ArunS-tack ArunS-tack deleted the dg branch May 31, 2021 16:50
shirodkara pushed a commit to shirodkara/julia that referenced this pull request Jun 9, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linear algebra Linear algebra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants