inference: Add some basic inference for PhiNode #41115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've been wondering about this for a long long time -- this is great. |
Member
Author
|
I have a couple more fixes here that I'll push shortly. |
| return (vtypes[slot_id(e)]::VarState).typ | ||
| elseif isa(e, GlobalRef) | ||
| return abstract_eval_global(e.mod, e.name) | ||
| elseif isa(e, PhiNode) |
Member
There was a problem hiding this comment.
I think it would be better to move this to abstract_eval_statement, since it can't be nested in anything.
| deleteat!(sv.stmt_info, i) | ||
| nexpr -= 1 | ||
| if oldidx < length(changemap) | ||
| changemap[oldidx + 1] = -1 |
Member
Author
There was a problem hiding this comment.
No, the changemap was just offset by one, but as a result, nothing was recorded for the last statement, but here I do need to know if the last statement got deleted (so I can update the relevant phi nodes if any), so I changed the ordering to be non-offset.
Keno
force-pushed
the
kf/phinodeinf
branch
2 times, most recently
from
3b71aa3 to
7a15866
Compare
PhiNode isn't really supported in lowered IR, but it is convenient to be able to emit it, particularly for code that is designed to perform transformations both on typed and on lowered IR (such as Diffractor). Moreover, we do actually supported phinodes in untyped IR both in the interpreter and in the compiler. At the moment, inference assumes that PhiNodes get treated as embedded constants, which is just not what the actual implementation does. At the very least, it should just leave PhiNodes alone in case they accidentally end up in lowered IR (rather than causing crashes), but we might as well give them some basic support.
JeffBezanson
approved these changes
Jun 23, 2021
oscardssmith
removed
the
merge me
Member
Author
|
Per discussion with the compiler team, I'd like to backport this to enable Diffractor and also because the previous behavior is quite arguable a bug. |
KristofferC
pushed a commit
that referenced
this pull request
Jun 30, 2021
PhiNode isn't really supported in lowered IR, but it is convenient to be able to emit it, particularly for code that is designed to perform transformations both on typed and on lowered IR (such as Diffractor). Moreover, we do actually supported phinodes in untyped IR both in the interpreter and in the compiler. At the moment, inference assumes that PhiNodes get treated as embedded constants, which is just not what the actual implementation does. At the very least, it should just leave PhiNodes alone in case they accidentally end up in lowered IR (rather than causing crashes), but we might as well give them some basic support. (cherry picked from commit bb52621)
51 tasks
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
PhiNode isn't really supported in lowered IR, but it is convenient to be able to emit it, particularly for code that is designed to perform transformations both on typed and on lowered IR (such as Diffractor). Moreover, we do actually supported phinodes in untyped IR both in the interpreter and in the compiler. At the moment, inference assumes that PhiNodes get treated as embedded constants, which is just not what the actual implementation does. At the very least, it should just leave PhiNodes alone in case they accidentally end up in lowered IR (rather than causing crashes), but we might as well give them some basic support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhiNode isn't really supported in lowered IR, but it is convenient
to be able to emit it, particularly for code that is designed to
perform transformations both on typed and on lowered IR (such as
Diffractor). Moreover, we do actually supported phinodes in untyped
IR both in the interpreter and in the compiler. At the moment,
inference assumes that PhiNodes get treated as embedded constants,
which is just not what the actual implementation does. At the very
least, it should just leave PhiNodes alone in case they accidentally
end up in lowered IR (rather than causing crashes), but we might
as well give them some basic support.