-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add filter(func) method
#41173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter(func) method
#41173
Conversation
|
I guess I'd need to add some tests. But please let me know if this feature is acceptable. |
base/array.jl
Outdated
| -4 | ||
| ``` | ||
| !!! compat "Julia 1.8" | ||
| This functionality requires at least Julia 1.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This functionality requires at least Julia 1.8 | |
| This method requires at least Julia 1.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
If this is to be done, I think it should be done consistently for |
See #35293 |
|
From triage: we can't do this for
|
Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: Johnny Chen <[email protected]>
Nice! Co-authored-by: Michael Abbott <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
Is this good to go now? |
|
Bump. Merge? |
| !!! compat "Julia 1.8" | ||
| This method requires at least Julia 1.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 1.9 right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| !!! compat "Julia 1.8" | |
| This method requires at least Julia 1.8. | |
| !!! compat "Julia 1.9" | |
| This method requires at least Julia 1.9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was hoping that GitHub provides a way to make a new PR from a comment like this. Alas...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created the old fashioned way: #47045.
No description provided.