Export jl_get_pgcstack from libjulia #41320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pgcstack symbol is special because embedders are supposed to define it themselves in localexec tls, and then access it that way. However, there is another case of of libraries that link against julia, but are not embedders, but rather plugins to be loaded later (e.g. CxxWrap). These do need access to the pgcstack, but do not have a priori access to the localexec of the embedder. Thus, re-export the `jl_get_pgcstack` function that provides access to our internal getter for the pgcstack.
vtjnash
approved these changes
Jun 22, 2021
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
SGTM. I think internally we don't use this function, but instead one of the more directly optimized calls?
Member
|
Can this please be backported to 1.7, see JuliaPackaging/Yggdrasil#3263 ? |
51 tasks
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
The pgcstack symbol is special because embedders are supposed to define it themselves in localexec tls, and then access it that way. However, there is another case of of libraries that link against julia, but are not embedders, but rather plugins to be loaded later (e.g. CxxWrap). These do need access to the pgcstack, but do not have a priori access to the localexec of the embedder. Thus, re-export the `jl_get_pgcstack` function that provides access to our internal getter for the pgcstack.
KristofferC
pushed a commit
that referenced
this pull request
Jul 5, 2021
The pgcstack symbol is special because embedders are supposed to define it themselves in localexec tls, and then access it that way. However, there is another case of of libraries that link against julia, but are not embedders, but rather plugins to be loaded later (e.g. CxxWrap). These do need access to the pgcstack, but do not have a priori access to the localexec of the embedder. Thus, re-export the `jl_get_pgcstack` function that provides access to our internal getter for the pgcstack. (cherry picked from commit e469a1e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pgcstack symbol is special because embedders are supposed to
define it themselves in localexec tls, and then access it that way.
However, there is another case of of libraries that link against
julia, but are not embedders, but rather plugins to be loaded later
(e.g. CxxWrap). These do need access to the pgcstack, but do not
have a priori access to the localexec of the embedder. Thus,
re-export the
jl_get_pgcstackfunction that provides accessto our internal getter for the pgcstack.