-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
[Codegen] Skip wb emission when they are no children objects #41439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Wow, that seemed to cause a surprising amount of CI chaos |
|
Bisected this to https://reviews.llvm.org/D106613 |
|
Adding this to the milestone so that we pick up https://reviews.llvm.org/D106613 at least, even if we don't backport this commit. |
|
The LLVM patch is probably not release-blocking, since AFAICT we don't actually hit the bug in 1.7. Once it's settled will be good to backport though. |
|
FWIW, it seems like we are potentially waiting for the next LLVM version, which disables the offending logic (via a better cost model), since I don't know how to fix it. |
|
@nanosoldier |
|
@nanosoldier |
|
Something went wrong when running your job: Unfortunately, the logs could not be uploaded. |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
|
PkgEval failed due to the network outage yesterday... |
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
Originally found by @pchintalapudi