Add support for measuring compile time per thread #42018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In situations where we run long-running server that spends non-trivial amount of time in the compilation we are happy to pay the cost to have this instrumentation always on. This PR allows us to enable permanent tracking (effectively switching the before/after switches moot) by calling `jl_track_compile_time_permanently()` method, and then providing `jl_cumulative_compile_time_ns_total()` to return the total time. Co-Authored-By: janrous-rai <[email protected]>
… track_compile_time_permanently()
Restores the ability to also track per-thread compilation time in addition to the global time we created in #41733. Co-Authored-By: janrous-rai <[email protected]>
|
CC: @janrous-rai, @Sacha0 |
|
Sorry we left this PR in draft for so long... does anyone actually care about this? Do we, @janrous-rai, @kpamnany? @vchuravy: would this be better done via Probes? Does this tie-in better to the overall tracing efforts, like #36870? |
|
I believe the other pr that changed the compilation accounting may replace
this. I'll need to take another look at it.
…On Sun, Jan 2, 2022, 09:21 Nathan Daly ***@***.***> wrote:
Sorry we left this PR in draft for so long... does anyone actually care
about this? Do we, @janrous-rai <https://github.com/janrous-rai>,
@kpamnany <https://github.com/kpamnany>?
@vchuravy <https://github.com/vchuravy>: would this be better done via
Probes? Does this tie-in better to the overall tracing efforts, like
#36870 <#36870>?
—
Reply to this email directly, view it on GitHub
<#42018 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATBN3JVSD7SXN7GRBZU7AV3UUB3RRANCNFSM5C4HJ27Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is branched out as a follow-up to #41762.
It restores the ability to also track per-thread compilation time in addition to the global time we created in #41733.