Circshift no longer throws error for empty array #42288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Terminological nit: these arrays are empty, not zero-dimensional. Zero-dimensional arrays are non-empty and have a single element. Arrays where at least one dimension has size zero are empty. Zero-dimensional arrays cannot be empty because there is no dimension to have size zero. |
stevengj
reviewed
Sep 17, 2021
JeffBezanson
added
arrays
getzze
changed the title
stevengj
approved these changes
Sep 18, 2021
KristofferC
pushed a commit
that referenced
this pull request
Sep 23, 2021
* Test circshift with 0-dim array * circshift returns dest array for a 0-dim array * use isempty instead of checking size (cherry picked from commit 144ed87)
84 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 28, 2021
* Test circshift with 0-dim array * circshift returns dest array for a 0-dim array * use isempty instead of checking size
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
* Test circshift with 0-dim array * circshift returns dest array for a 0-dim array * use isempty instead of checking size
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
* Test circshift with 0-dim array * circshift returns dest array for a 0-dim array * use isempty instead of checking size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41402
Return the
destarray if any dimension ofsrcis 0. Because of the 0-dimension, no value is stored in the array anddest==src.