Skip to content

Base: fix tryparse(Bool, " ") #42623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

Base: fix tryparse(Bool, " ") #42623

merged 1 commit into from
Oct 13, 2021

Conversation

@barucden
Copy link
Contributor

The while conditions were incorrectly ordered, resulting in BoundsError.

Fixes #42616.

@barucden
Base: fix tryparse(Bool, " ")
2cd8aa0 
The `while` conditions were incorrectly ordered, resulting in
`BoundsError`.
@KristofferC KristofferC added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Oct 13, 2021
@dkarrasch
Copy link
Member

Let's rerun CI, something went awefully wrong.

@dkarrasch dkarrasch closed this Oct 13, 2021
@dkarrasch dkarrasch reopened this Oct 13, 2021
@DilumAluthge DilumAluthge added bugfix This change fixes an existing bug strings "Strings!" labels Oct 13, 2021
@fredrikekre fredrikekre merged commit 9739f50 into JuliaLang:master Oct 13, 2021
@barucden barucden deleted the tryparse-bool-fix branch October 13, 2021 14:55
@DilumAluthge
Copy link
Member

Thank you @barucden!

KristofferC pushed a commit that referenced this pull request Oct 18, 2021
@barucden @KristofferC
Base: fix tryparse(Bool, " ") (#42623)
15fef0d 
The `while` conditions were incorrectly ordered, resulting in
`BoundsError`.

(cherry picked from commit 9739f50)
@KristofferC KristofferC mentioned this pull request Oct 18, 2021
Merged
84 tasks
KristofferC pushed a commit that referenced this pull request Oct 19, 2021
@barucden @KristofferC
Base: fix tryparse(Bool, " ") (#42623)
1521ccc 
The `while` conditions were incorrectly ordered, resulting in
`BoundsError`.

(cherry picked from commit 9739f50)
@KristofferC KristofferC mentioned this pull request Oct 19, 2021
Merged
95 tasks
@KristofferC KristofferC mentioned this pull request Nov 8, 2021
Merged
66 tasks
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
@barucden @KristofferC
Base: fix tryparse(Bool, " ") (#42623)
1d03f3e 
The `while` conditions were incorrectly ordered, resulting in
`BoundsError`.

(cherry picked from commit 9739f50)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@barucden @LilithHafner
Base: fix tryparse(Bool, " ") (JuliaLang#42623)
86e3e9a 
The `while` conditions were incorrectly ordered, resulting in
`BoundsError`.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@barucden @LilithHafner
Base: fix tryparse(Bool, " ") (JuliaLang#42623)
d02a644 
The `while` conditions were incorrectly ordered, resulting in
`BoundsError`.
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@barucden @staticfloat
Base: fix tryparse(Bool, " ") (#42623)
fa6f4f0 
The `while` conditions were incorrectly ordered, resulting in
`BoundsError`.

(cherry picked from commit 9739f50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KristofferC KristofferC KristofferC approved these changes

Assignees

No one assigned

Labels

bugfix This change fixes an existing bug strings "Strings!"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tryparse(Bool, " ") throws an error instead of returning nothing

5 participants

@barucden @dkarrasch @DilumAluthge @KristofferC @fredrikekre