Skip to content

Disable "Test spawning a lot of tasks" on Windows #43125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 19, 2021
Merged

Disable "Test spawning a lot of tasks" on Windows #43125

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a79812
Don't hide output from spawnmany test script
tkf Nov 18, 2021
6f916e6
Disable "Test spawning a lot of tasks" on Windows
tkf Nov 18, 2021
0e85d8d
Remove error log; skip on Windows only for large n
tkf Nov 19, 2021
407a09e
Show more info upon failure
tkf Nov 19, 2021
61d3328
We can also still do `@test success(proc)` after the other tests
DilumAluthge Nov 19, 2021
3e8a399
Make the two branches of the conditional more symmetric
DilumAluthge Nov 19, 2021
e113ab9
If `!success(proc)`, print a variety of debugging data
DilumAluthge Nov 19, 2021
25f06a7
Always skip tests on Windows
tkf Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions test/threads.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,11 @@ close(proc.in)
# Not using threads_exec.jl for better isolation, reproducibility, and a
# tighter timeout.
script = "profile_spawnmany_exec.jl"
cmd = `$(Base.julia_cmd()) --depwarn=error --rr-detach --startup-file=no $script`
cmd_base = `$(Base.julia_cmd()) --depwarn=error --rr-detach --startup-file=no $script`
@testset for n in [20000, 200000, 2000000]
proc = run(ignorestatus(setenv(cmd, "NTASKS" => n; dir = @__DIR__)); wait = false)
cmd = ignorestatus(setenv(cmd_base, "NTASKS" => n; dir = @__DIR__))
cmd = pipeline(cmd; stdout = stderr, stderr)
proc = run(cmd; wait = false)
done = Threads.Atomic{Bool}(false)
timeout = false
timer = Timer(100) do _
Expand All @@ -200,7 +202,15 @@ close(proc.in)
done[] = true
close(timer)
end
@test success(proc)
if ( !success(proc) ) || ( timeout )
@error "A \"spawn and wait lots of tasks\" test failed" n proc.exitcode proc.termsignal success(proc) timeout
end
if Sys.iswindows()
# Known failure: https://github.com/JuliaLang/julia/issues/43124
@test_skip success(proc)
else
@test success(proc)
end
@test !timeout
end
end