Allow underscores in big"[float]" #43346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the failing test is unrelated to this PR and related to #43125 instead. |
oscardssmith
reviewed
Dec 6, 2021
| @test_throws ArgumentError big"1_0_0_0_" | ||
| @test_throws ArgumentError big"_1_0_0_0" | ||
|
|
||
| @test big"1_0.2_5" == BigFloat(10.25) |
There was a problem hiding this comment.
Do these tests belong in int.jl? I guess it doesn't really matter...
There was a problem hiding this comment.
Fair point. It's a consequence of the big"[float]" code being in base/int.jl, which was true already before this PR.
There was a problem hiding this comment.
fair enough. Not worth fixing.
oscardssmith
approved these changes
Dec 6, 2021
oscardssmith
added
bignums
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40368