Show only the "Test Passed" message when a test passes #43795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
approved these changes
Jan 13, 2022
Member
|
Probably needs a rebase on the latest master (to pick up the fixes for 32-bit CI that were recently merged to master). |
nickrobinson251
force-pushed
the
npr/show-pass-status-only
branch
2 times, most recently
from
5726a9d to
443cc78
Compare
Contributor
Author
|
rebased |
This restores the behaviour of how `@test` shows a test pass in Julia v1.0 - v1.6, reverting the display changes that resulted when we began storing more info in the `Pass` type in JuliaLang#36879. Closes JuliaLang#43794.
nickrobinson251
force-pushed
the
npr/show-pass-status-only
branch
from
443cc78 to
f7cd6be
Compare
N5N3
pushed a commit
to N5N3/julia
that referenced
this pull request
Jan 24, 2022
This restores the behavior of how `at-test` shows a test pass in Julia v1.0 - v1.6, reverting the display changes introduced when storing more info in the `Pass` type in JuliaLang#36879, closes JuliaLang#43794.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
This restores the behavior of how `at-test` shows a test pass in Julia v1.0 - v1.6, reverting the display changes introduced when storing more info in the `Pass` type in JuliaLang#36879, closes JuliaLang#43794.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
This restores the behavior of how `at-test` shows a test pass in Julia v1.0 - v1.6, reverting the display changes introduced when storing more info in the `Pass` type in JuliaLang#36879, closes JuliaLang#43794.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the behaviour of how
@testshowsa test pass in Julia v1.0 - v1.6, reverting the
display changes that resulted when we began storing
more info in the
Passtype in #36879.Closes #43794.
We could also change
@test_throwsto show onlyTest Passedrather thanThrown/Messageinfo if consistency is desirable (but the issues mentioned in #43794 don't apply so much to theThrown/Messageinfo in@test_throws, so i've left that alone for now)