Fix build warning in gc-alloc-profiler.cpp: cast to (size_t) #44180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilterp
approved these changes
Feb 15, 2022
oscardssmith
approved these changes
Feb 16, 2022
|
Why is CI in such bad shape on this? Perhaps worth a rebase? |
|
yeah, this branched from a few days ago when everything was broken. A rebase should fix it. |
NHDaly
force-pushed
the
nhd-build-warning--allocs-profiler
branch
2 times, most recently
from
3bfc736 to
8d28f62
Compare
`std::vector::size()` returns a `size_t`, so we need to cast the int `jl_n_threads` to a `size_t` for the comparison.
NHDaly
force-pushed
the
nhd-build-warning--allocs-profiler
branch
from
8d28f62 to
2d684df
Compare
|
Oops, thanks @DilumAluthge for merging in master. i hadn't noticed, and pushed up a rebase. Please feel free to merge once CI is green - i'll be on vacation for the next 3 weeks 😊 |
33 tasks
KristofferC
pushed a commit
that referenced
this pull request
Feb 19, 2022
`std::vector::size()` returns a `size_t`, so we need to cast the int `jl_n_threads` to a `size_t` for the comparison. (cherry picked from commit 15dcd5b)
staticfloat
pushed a commit
to JuliaCI/julia-buildkite-testing
that referenced
this pull request
Mar 2, 2022
…ng#44180) `std::vector::size()` returns a `size_t`, so we need to cast the int `jl_n_threads` to a `size_t` for the comparison.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…ng#44180) `std::vector::size()` returns a `size_t`, so we need to cast the int `jl_n_threads` to a `size_t` for the comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::vector::size()returns asize_t, so we need to cast the intjl_n_threadsto asize_tfor the comparison.@IanButterworth: this addresses the build warning you reported on Slack. Thanks for that! 😊
CC: @vilterp