- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.7k
          make Base.return_types interface similar to code_typed
          #44533
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    6635c1b    to
    7f1e461      
    Compare
  
    Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
10134cf    to
    02f8e63      
    Compare
  
    
    
  aviatesk 
      added a commit
      that referenced
      this pull request
    
      Mar 11, 2022 
    
    
      
  
    
      
    
  
Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
    
  aviatesk 
      added a commit
      that referenced
      this pull request
    
      Mar 14, 2022 
    
    
      
  
    
      
    
  
Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
    
  aviatesk 
      added a commit
      that referenced
      this pull request
    
      Mar 14, 2022 
    
    
      
  
    
      
    
  
Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
    
  aviatesk 
      added a commit
      that referenced
      this pull request
    
      Mar 14, 2022 
    
    
      
  
    
      
    
  
Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
    
  aviatesk 
      added a commit
      that referenced
      this pull request
    
      Mar 14, 2022 
    
    
      
  
    
      
    
  
Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
    
  aviatesk 
      added a commit
      that referenced
      this pull request
    
      Mar 14, 2022 
    
    
      
  
    
      
    
  
Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
    
  aviatesk 
      added a commit
      that referenced
      this pull request
    
      Mar 14, 2022 
    
    
      
  
    
      
    
  
Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
    
  aviatesk 
      added a commit
      that referenced
      this pull request
    
      Mar 14, 2022 
    
    
      
  
    
      
    
  
Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
    
  aviatesk 
      added a commit
      that referenced
      this pull request
    
      Mar 15, 2022 
    
    
      
  
    
      
    
  
Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
    
  aviatesk 
      added a commit
      that referenced
      this pull request
    
      Mar 15, 2022 
    
    
      
  
    
      
    
  
Especially, it should be more consistent with the other reflection utilities defined in reflection.jl if the optional `interp::AbstractInterpreter` argument is passed as keyword one.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
interp::AbstractInterpreterargument is passed as keyword one.
/cc @maleadt this will require one-line modification in GPUCompiler code, but I'm willing to take that job if we're okay with this change.