Fix some inference failures in Base.require call graph #44628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Mar 15, 2022
vtjnash
reviewed
Mar 15, 2022
KristofferC
reviewed
Mar 15, 2022
aviatesk
approved these changes
Mar 16, 2022
aviatesk
reviewed
Mar 16, 2022
|
Thanks @aviatesk! Freebsd and Linux32 seem stuck, but everything else passes so I will just merge. |
KristofferC
added a commit
that referenced
this pull request
Apr 20, 2022
Discovered via JET. This also causes `make_aliases` to always return a `Vector{SimpleVector}` as its first argument.
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Kristoffer Carlsson <[email protected]>
(cherry picked from commit cc60657)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found another package, RoundingIntegers.jl, that invalidates
Base.require, which is particularly bad to invalidate since it has to be recompiled before loading the next package; if it happens repeatedly it can substantially slow loading. I finally decided to just go through the JET report onBase.requireand fix most of the things that I could fix that weren't already being handled in #44500.I am not certain whether the change to
make_aliases(always returning aVector{SimpleVector}) is wise, but the tests pass so 🤷.