Skip to content

Reland "IO: tie lifetime of handle field to container" #44883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2022
Merged

Reland "IO: tie lifetime of handle field to container" #44883

merged 2 commits into from
Apr 14, 2022

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Apr 6, 2022 •
edited
Loading

Depends on #44881

Reverts a400a24 (#43924).

Relands #43218.

@vtjnash vtjnash force-pushed the jn/bad-stdin-tests branch 2 times, most recently from 6552c91 to 2a07bcf Compare April 11, 2022 17:07
Base automatically changed from jn/bad-stdin-tests to master April 12, 2022 05:11
@vtjnash vtjnash force-pushed the jn/io-handle-life branch from 4f5cf90 to 1b8f074 Compare April 12, 2022 16:46
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Apr 12, 2022
@DilumAluthge
Copy link
Member

DilumAluthge commented Apr 12, 2022

analyzegc is failing. Let's rerun to see if it still fails.

@vtjnash vtjnash force-pushed the jn/io-handle-life branch from c118abd to 6573350 Compare April 12, 2022 20:37
@vtjnash
Copy link
Member Author

vtjnash commented Apr 12, 2022

oh, sorry, that was a rebase mistake I had forgotten to fix again

@vtjnash
Reland "IO: tie lifetime of handle field to container (#43218)"
f3fe012 
Reverts a400a24 (#43924).

Fix lifetime issues with the original attempt. We do not need to prevent
it from being GC-finalized: only to make sure it does not conflict with
a concurrent uv_close callback.
@vtjnash vtjnash force-pushed the jn/io-handle-life branch from 9a1b839 to f3fe012 Compare April 13, 2022 20:27
@vtjnash
Copy link
Member Author

vtjnash commented Apr 13, 2022

For safety, rerunning after #44956, though I developed them together, so it should be fine

@vtjnash vtjnash merged commit 72cd1c4 into master Apr 14, 2022
@vtjnash vtjnash deleted the jn/io-handle-life branch April 14, 2022 20:33
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Apr 14, 2022
maleadt referenced this pull request Apr 20, 2022
@pchintalapudi
Protect shared JIT variables from being modified unsafely (#44914)
ab11173
DilumAluthge added a commit that referenced this pull request Apr 21, 2022
@DilumAluthge
Revert "Reland "IO: tie lifetime of handle field to container (#43218)…
95e5fd9 
…" (#44883)"

This reverts commit 72cd1c4.
@DilumAluthge DilumAluthge mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtjnash @DilumAluthge