Skip to content

Conversation

@KristofferC
Copy link
Member

No description provided.

@KristofferC KristofferC requested a review from ViralBShah April 29, 2022 13:19
@DilumAluthge DilumAluthge added excision Removal of code from Base or the repository stdlib Julia's standard library labels Apr 29, 2022
@ViralBShah ViralBShah marked this pull request as draft April 29, 2022 15:59
@ViralBShah
Copy link
Member

Is it meaningful to run pkgeval here?

@KristofferC
Copy link
Member Author

Is it meaningful to run pkgeval here?

Somewhat since it moves out DelimitedFiles from the sysimage which could, in theory, have some adverse effects.

@nanosoldier runtests(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@ViralBShah
Copy link
Member

I thought a lot more packages would be affected. Unless I am reading something incorrectly, It seems like this is good to merge.

@ViralBShah
Copy link
Member

Should DelimitedFiles.jl be registered in General before or after this merge?

cc @giordano

@giordano
Copy link
Member

giordano commented May 3, 2022

I presume it should, yes

@ViralBShah
Copy link
Member

ViralBShah commented May 14, 2022

Looks like we should go ahead with this and merge.

@KristofferC KristofferC marked this pull request as ready for review May 18, 2022 07:56
@KristofferC KristofferC force-pushed the kc/delimited_no_sysimage branch from 2f68920 to 0b07de7 Compare May 18, 2022 08:00
@KristofferC
Copy link
Member Author

Should be good to go now I think

@ViralBShah
Copy link
Member

I say we hit merge!

@oscardssmith oscardssmith merged commit 2159bfb into master May 18, 2022
@oscardssmith oscardssmith deleted the kc/delimited_no_sysimage branch May 18, 2022 18:02
@nalimilan
Copy link
Member

@KristofferC Have you kept the section of the manual about DelimitedFiles on purpose? Just to ensure we do the same thing for other stdlibs that we move out.

@ViralBShah
Copy link
Member

DelimitedFiles is not yet moved out of stdlibs. It is just not in the system image. There are other issues to work through (#45540 (comment)) before it can truly move out, and at that point we should remove the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

excision Removal of code from Base or the repository stdlib Julia's standard library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants