-
-
Couldn't load subscription status.
- Fork 5.7k
Use externally hosted DelimitedFiles and move it out of the sysimage #45121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is it meaningful to run |
Somewhat since it moves out DelimitedFiles from the sysimage which could, in theory, have some adverse effects. @nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
|
I thought a lot more packages would be affected. Unless I am reading something incorrectly, It seems like this is good to merge. |
|
Should DelimitedFiles.jl be registered in General before or after this merge? cc @giordano |
|
I presume it should, yes |
|
Looks like we should go ahead with this and merge. |
2f68920 to
0b07de7
Compare
|
Should be good to go now I think |
|
I say we hit merge! |
|
@KristofferC Have you kept the section of the manual about DelimitedFiles on purpose? Just to ensure we do the same thing for other stdlibs that we move out. |
|
DelimitedFiles is not yet moved out of stdlibs. It is just not in the system image. There are other issues to work through (#45540 (comment)) before it can truly move out, and at that point we should remove the docs. |
No description provided.