[v1.8] env_project_file correctly handle directories #45284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I changed the branch to be against the backport branch (so it will go through PkgEval) and apparently that messed things up. Perhaps it needs to be rebased... Sorry. |
KristofferC
force-pushed
the
sb/env_project_file
branch
from
ca2a94a to
9eef9cc
Compare
On 1.7 and 1.8, if you provide a directory to `env_project_file`, it will return `true` even if there is a project file in the directory. Note that this PR is against the release-1.8: it was fixed on master by #44318, so we could also backport that one.
KristofferC
force-pushed
the
sb/env_project_file
branch
from
9eef9cc to
dea3992
Compare
KristofferC
approved these changes
May 12, 2022
KristofferC
added
packages
|
Seems like testing fails on e.g. tester_win64. |
vtjnash
changed the title
|
It fails on all systems. Seems like the test is just written incorrectly? |
vtjnash
reviewed
May 27, 2022
Co-authored-by: Jameson Nash <[email protected]>
|
#44318 was backported so this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 1.7 and 1.8, if you provide a directory to
env_project_file, it will returntrueeven if there is a project file in the directory.Note that this PR is against the release-1.8 branch: it was fixed on master by #44318, so we could also backport that one.