Skip to content

Conversation

@Keno
Copy link
Member

@Keno Keno commented Aug 19, 2022

This change broke Revise. @JeffBezanson and I discussed this with a number of folks and the consensus was that:

  1. We don't think the src/base thing really makes much sense.
  2. We don't like not having symlinks, because that makes everything show up twice in grep and IDEs
  3. Having Revise working is significantly more important than the original bug this fixed, which seems like it should be fixable by other Makefile improvements without touching the directory structure.

Reverts #45441.

@Keno
Copy link
Member Author

Keno commented Aug 20, 2022

Both Jeff and Jameson are on vacation now, but Jeff told me to do this in person, so I'll just consider than a review approval ;).

@Keno Keno merged commit a77ba79 into master Aug 20, 2022
@Keno Keno deleted the revert-45441-jn/make_base_files branch August 20, 2022 01:42
@DilumAluthge DilumAluthge added the revert This reverts a previously merged PR. label Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

revert This reverts a previously merged PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants