inference: improve isa-constraint propagation for iskindtype objects
#46712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently our inference isn't able to propagate `isa`-based type
constraint for cases like `isa(Type{<:...}, DataType)` since
`typeintersect` may return `Type` object itself when taking `Type`
object and `iskindtype`-object.
This case happens in the following kind of situation (motivated by the
discussion at <#46553 (comment)>):
```julia
julia> function isa_kindtype(T::Type{<:AbstractVector})
if isa(T, DataType)
# `T` here should be inferred as `DataType` rather than `Type{<:AbstractVector}`
return T.name.name # should be inferred as ::Symbol
end
return nothing
end
isa_kindtype (generic function with 1 method)
julia> only(code_typed(isa_kindtype; optimize=false))
CodeInfo(
1 ─ %1 = (T isa Main.DataType)::Bool
└── goto #3 if not %1
2 ─ %3 = Base.getproperty(T, :name)::Any
│ %4 = Base.getproperty(%3, :name)::Any
└── return %4
3 ─ return Main.nothing
) => Any
```
This commit improves the situation by adding a special casing for
abstract interpretation, rather than changing the behavior of
`typeintersect`.
aviatesk
force-pushed
the
avi/typetypeinf2
branch
from
7e48407 to
3136189
Compare
vtjnash
approved these changes
Sep 12, 2022
|
Test failures looks unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our inference isn't able to propagate
isa-based type constraint for cases likeisa(Type{<:...}, DataType)sincetypeintersectmay returnTypeobject itself when takingTypeobject andiskindtype-object.This case happens in the following kind of situation (motivated by the discussion at #46553 (comment)):
This commit improves the situation by adding a special casing for abstract interpretation, rather than changing the behavior of
typeintersect.