Skip to content

improve inferrability of create_expr_cache #46801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

improve inferrability of create_expr_cache #46801

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0340af1
improve inferrability of `create_expr_cache`
ranocha Sep 16, 2022
26c5876
Merge branch 'master' into hr/create_expr_cache
ranocha Oct 17, 2022
5fa7095
Merge branch 'master' into hr/create_expr_cache
KristofferC Oct 19, 2022
6afc3bf
Merge branch 'master' into hr/create_expr_cache
KristofferC Oct 28, 2022
73ed3d7
Merge branch 'master' into hr/create_expr_cache
ranocha Oct 31, 2022
5741f57
Merge branch 'master' into hr/create_expr_cache
KristofferC Nov 2, 2022
afafbd1
Merge branch 'master' into hr/create_expr_cache
ranocha Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions base/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1710,11 +1710,12 @@ function create_expr_cache(pkg::PkgId, input::String, output::String, concrete_d
stderr = internal_stderr, stdout = internal_stdout),
"w", stdout)
# write data over stdin to avoid the (unlikely) case of exceeding max command line size
write(io.in, """
io_in = io.in::PipeEndpoint
write(io_in, """
Base.include_package_for_output($(pkg_str(pkg)), $(repr(abspath(input))), $(repr(depot_path)), $(repr(dl_load_path)),
$(repr(load_path)), $deps, $(repr(source_path(nothing))))
""")
close(io.in)
close(io_in)
return io
end

Expand Down