Skip to content

gc: add missing root for binding->ty field #46806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2022
Merged

gc: add missing root for binding->ty field #46806

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4023cf1
gc: add missing root for binding->ty field
vtjnash Sep 16, 2022
335c004
Update src/gc.c
vtjnash Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2497,6 +2497,16 @@ module_binding: {
// Record the size used for the box for non-const bindings
gc_heap_snapshot_record_module_to_binding(binding->parent, b);
(void)vb;
jl_value_t *ty = jl_atomic_load_relaxed(&b->ty);
if (ty && ty != (jl_value_t*)jl_any_type) {
verify_parent2("module", binding->parent,
&b->ty, "binding(%s)", jl_symbol_name(b->name));
if (gc_try_setmark(ty, &binding->nptr, &tag, &bits)) {
new_obj = ty;
gc_repush_markdata(&sp, gc_mark_binding_t);
goto mark;
}
}
jl_value_t *value = jl_atomic_load_relaxed(&b->value);
jl_value_t *globalref = jl_atomic_load_relaxed(&b->globalref);
if (value) {
Expand Down