Heap Snapshot #46862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vtjnash merged 25 commits into JuliaLang:master from apaz-cli:pv-heap-snapshot

Oct 5, 2022

Member

apaz-cli commented Sep 22, 2022

This picks up from the work done on #42286.

apaz-cli and others added 2 commits

September 22, 2022 11:23


          Added heap profiler.

01b6af2

Co-Authored-By: Dean De Leo <[email protected]>
Co-Authored-By: Nathan Daly <[email protected]>
Co-Authored-By: Pete Vilter <[email protected]>
Co-Authored-By: Valentin Churavy <[email protected]>
Co-Authored-By: @whatsthecraic


          Updated/Rewrote heap snapshot PR. Moved to Profile package, optimized…

03addad

…, and added all_one flag.

Co-Authored-By: Jameson Nash <[email protected]>

vtjnash reviewed

View reviewed changes

src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc-heap-snapshot.cpp Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc.c Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc.c Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc.c Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc.c Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc.c Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

stdlib/Profile/src/Profile.jl Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

stdlib/Profile/test/runtests.jl Outdated Show resolved Hide resolved

vchuravy mentioned this pull request

Heap snapshot #42286

Closed

29 tasks

apaz-cli and others added 14 commits

September 23, 2022 10:09


          remove newline

72206ea

Co-authored-by: Jameson Nash <[email protected]>


          Update src/gc-heap-snapshot.cpp

8acc854

This is the only occurrence of a brace on the following line.

Co-authored-by: Jameson Nash <[email protected]>


          Removed unnecessary cast

042bc5b

Co-authored-by: Jameson Nash <[email protected]>


          Remove extra todo

f300a21

Co-authored-by: Jameson Nash <[email protected]>


          Update src/gc.c

3b5a832

Co-authored-by: Jameson Nash <[email protected]>


          Added cleanup to test.

19fbec8


          Added back cast, removed check for jl_buff_tag.

325ca8b


          Added docs about all_one.

a814039


          Added take_heap_snapshot() to Profile docs.

59ce09b


          TODOs only for gc_heap_snapshot_record

5a40b9e


          Changed stack frame size to 0 so synthetic root node doesn't show up …

868c0ff

…in Chrome devtools.


          Remove gc_heap_snapshot_record_module_to_binding

Co-authored-by: Jameson Nash <[email protected]>


          Fully removed record module edge.

dc8df96


          Using jl_atomic_load_relaxed() to load atomic fields from binding.

89cf29e

apaz-cli added 2 commits

September 27, 2022 10:39


          Fixed style again.

f7d2978


          Fixed trailing whitespace and added atomic load to appease the saniti…

94f20ef

…zer.

vtjnash reviewed

View reviewed changes

src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved


          Put the brace back on a new line, as requested.

3d49b4b

Member

IanButterworth commented Sep 29, 2022

I just wanted to say that I tried this out after running some extensive code and it saved the snapshot with no issue and it loaded in devtools. Thanks for pushing this forward!

Also, a NEWS entry would be good I think


          style: Moved all { after functions in gc-heap-snapshot.c to a new line.

1fdd355

vtjnash reviewed

View reviewed changes

stdlib/Profile/docs/src/index.md Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc.c Outdated Show resolved Hide resolved

vtjnash reviewed

View reviewed changes

src/gc-heap-snapshot.h Outdated Show resolved Hide resolved

apaz-cli and others added 5 commits

October 3, 2022 11:41


          Update style

adc9e59

Co-authored-by: Jameson Nash <[email protected]>


          Updated the description of take_heap_snapshot()

e511021


          Updated the description of take_heap_snapshot()

3bf039a


          Fixed style

2ae020d


          Added cast from task to value.

3aa4fdb

vtjnash added the merge me label

Member

NHDaly commented Oct 5, 2022

INCREDIBLE!
Thanks so much @apaz-cli for picking this up! We over at RAI were just dancing, celebrating this work. We are super excited! 😭
Many thanks, @apaz-cli, @vtjnash, @vchuravy!
- Love, @vilterp and me ❤️

vtjnash merged commit 956e0a3 into JuliaLang:master

vtjnash added needs news and removed merge me labels

antoine-levitt added this to the 1.12 milestone

Contributor

PallHaraldsson commented Oct 26, 2022 •

edited

Loading

@antoine-levitt what's the point of adding "to the 1.12 milestone"? It was already merged, so in 1.9-DEV already! I assume 1.12 was in error (since far away), you meant to add a different version number and/or change elsewhere?

vtjnash removed this from the 1.12 milestone

Contributor

antoine-levitt commented Oct 26, 2022

I think my pocket did that, sorry!

JeffBezanson removed the needs news label

nickrobinson251 mentioned this pull request

Add heap snapshot endpoint JuliaPerf/ProfileEndpoints.jl#12

Merged

maleadt mentioned this pull request

Memory leak when running GPU broadcast in a loop JuliaGPU/oneAPI.jl#327

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet