Skip to content

InteractiveUtils [cosmetic]: tidy editor definitions #47048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2022
Merged

InteractiveUtils [cosmetic]: tidy editor definitions #47048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c92fff8
InteractiveUtils [cosmetic]: tidy editor definitions
StefanKarpinski Oct 4, 2022
e0fa724
Update stdlib/InteractiveUtils/src/editless.jl
StefanKarpinski Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions stdlib/InteractiveUtils/src/editless.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,10 @@ function define_default_editors()
`$cmd $path`
end
# vim family
for (editors, wait) in [[Any["vim", "vi", "nvim", "mvim"], true],
[Any["\bgvim"], false]]
for (editors, wait) in [
[["vim", "vi", "nvim", "mvim"], true],
[[r"\bgvim"], false],
]
define_editor(editors; wait) do cmd, path, line, column
cmd = line == 0 ? `$cmd $path` :
column == 0 ? `$cmd +$line $path` :
Expand All @@ -135,27 +137,31 @@ function define_default_editors()
define_editor("nano"; wait=true) do cmd, path, line, column
cmd = `$cmd +$line,$column $path`
end
# emacs (must check that emacs not running in -t/-nw before regex match for general emacs)
for (editors, wait) in [[Any[r"\bemacs"], false],
[Any[r"\bemacs\b.*\s(-nw|--no-window-system)\b", r"\bemacsclient\b.\s*-(-?nw|t|-?tty)\b"], true]]
# emacs (must check that emacs not running in -t/-nw
# before regex match for general emacs)
for (editors, wait) in [
[[r"\bemacs"], false],
[[r"\bemacs\b.*\s(-nw|--no-window-system)\b",
r"\bemacsclient\b.\s*-(-?nw|t|-?tty)\b"], true],
]
define_editor(editors; wait) do cmd, path, line, column
`$cmd +$line:$column $path`
end
end
# Other editors
# other editors
define_editor("gedit") do cmd, path, line, column
`$cmd +$line:$column $path`
end
define_editor(Any["micro", "kak"]; wait=true) do cmd, path, line, column
define_editor(["micro", "kak"]; wait=true) do cmd, path, line, column
`$cmd +$line $path`
end
define_editor(Any["hx", "helix"]; wait=true) do cmd, path, line, column
define_editor(["hx", "helix"]; wait=true) do cmd, path, line, column
`$cmd $path:$line:$column`
end
define_editor(["textmate", "mate", "kate"]) do cmd, path, line, column
`$cmd $path -l $line`
end
define_editor(Any[r"\bsubl", r"\batom", "pycharm", "bbedit"]) do cmd, path, line, column
define_editor([r"\bsubl", r"\batom", "pycharm", "bbedit"]) do cmd, path, line, column
`$cmd $path:$line`
end
define_editor(["code", "code-insiders"]) do cmd, path, line, column
Expand Down