Skip to content

make REPL completions robust against expanduser throwing #47058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

make REPL completions robust against expanduser throwing #47058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion stdlib/REPL/src/REPLCompletions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,12 @@ function complete_path(path::AbstractString, pos::Int; use_envpath=false, shell_
end

function complete_expanduser(path::AbstractString, r)
expanded = expanduser(path)
expanded =
try expanduser(path)
catch e
e isa ArgumentError || rethrow()
path
end
return Completion[PathCompletion(expanded)], r, path != expanded
end

Expand Down
3 changes: 3 additions & 0 deletions stdlib/REPL/test/replcompletions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,6 +1099,9 @@ let s, c, r
s = "\"~"
@test "tmpfoobar/" in c
c,r = test_complete(s)
s = "\"~user"
c, r = test_complete(s)
@test isempty(c)
rm(dir)
end
end
Expand Down