quote variable name in UndefVarError and UndefKeywordError
#47077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
approved these changes
Oct 6, 2022
KristofferC
force-pushed
the
kc/quote_var_error
branch
from
3d3fdce to
03860b9
Compare
aviatesk
approved these changes
Oct 6, 2022
KristofferC
force-pushed
the
kc/quote_var_error
branch
from
03860b9 to
fb014bc
Compare
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Oct 14, 2022
martinholters
added a commit
to JuliaLang/Compat.jl
that referenced
this pull request
Nov 8, 2022
martinholters
added a commit
to JuliaLang/Compat.jl
that referenced
this pull request
Nov 9, 2022
martinholters
added a commit
to JuliaLang/Compat.jl
that referenced
this pull request
Feb 18, 2023
(cherry picked from commit 6e1b40c)
martinholters
added a commit
to JuliaLang/Compat.jl
that referenced
this pull request
Feb 18, 2023
(cherry picked from commit 6e1b40c)
martinholters
added a commit
to JuliaLang/Compat.jl
that referenced
this pull request
Feb 18, 2023
(cherry picked from commit 6e1b40c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error message like
ERROR: UndefVarError: variable not definedcan be a bit confusing since the variable name (variable) blends into the text. Therefore I think it makes sense to quote the variable name. Here i opted for`but I guess one could argue for"as well.